build: updates rust version and WASM crates to latest versions #19

lanterno · 2025-09-01T11:53:55Z

Description

With the merge of the last PR #17, the project is now ready to run with Rust 1.89 (latest stable version as of the time of writing).
In the PR, I update Rust version, and also update all the WASM libraries to the latest versions.

Notice the change in the script file scripts/build-package.sh where this change arises from a very subtle change in the workings of the library wasm-bindgen.
This encourages a rethink on this part of the build script to avoid future bugs.

Next steps

In the following PR, I'll update the docknetwork crypto libraries to the latest versions. In fact, this PR is a prerequisite to updating the libraries as the dependencies conflict otherwise.

PR checklist

Run yarn install; yarn build; yarn test to make sure everything runs as before.
The commit message(s) follow conventional commits
Documentation has been added / updated (for bug fixes / features)
Changes follow the contributing document.

Does this PR introduce a breaking change?

Yes
No

Which merge strategy will you use?

Squash
Rebase (REVIEW COMMITS)

lanterno · 2025-09-01T12:35:45Z

The build failed, and by some investigation, I found the reason to be the github action https://github.com/jetli/wasm-pack-action was using version 'v0.9.1'.
By replacing this with a direct instal of the latest version of wasm-pack, the build now succeeds.

lanterno · 2025-09-01T14:16:43Z

Now, the tests fail with error

A worker process has failed to exit gracefully and has been force exited. This is likely caused by tests leaking due to improper teardown. Try running with --detectOpenHandles to find leaks. Active timers can also cause this, ensure that .unref() was called on them.
Test Suites: 1 failed, 12 passed, 13 total
Tests:       2 skipped, 145 passed, 147 total
Snapshots:   0 total
Time:        149.43 s

I'm guessing that's because of a memory leak indeed. I don't notice this on my local machine, but I'll try to improve the tests anyway, and see if that makes a difference.

lanterno · 2025-09-01T14:30:40Z

Update: Rerunning the tests with no code updates succeeded with no issues.

I'll leave this issue for now, and we can come back to this problem later after the final update of the libraries.

lovesh · 2025-09-02T09:35:51Z

Cargo.toml

+wasm-bindgen = "= 0.2.100"
 dlmalloc = { version = "0.2.6", features = ["global"], optional = true }
-serde_with = { version = "1.10.0", default-features = false, features = ["macros"] }
+serde_with = { version = "3.14.0", default-features = false, features = ["macros"] }


Upgrading this caused the serialization to change which is a breaking change so we need adapt in the TS lib (these tests specifically). The old serialized data used in those tests is here.
Is there a feature that you want from the upgraded version of this dependency?

Upgrading this .... The old serialized data used in those tests is here.

Oh! It didn't come to mind to look at the crypto-wasm-ts until I finished the updates here. Now, I'm thinking maybe I need to start running the crypto-wasm-ts tests on this library today.

Is there a feature that you want from the upgraded version of this dependency?

Not really! I was just worried that it's lagging behind with 2 major versions. However, since there's no incompatibility problems raised by this so far, I can just postpone until later to avoid having many issues to solve in crypto-wasm-ts at the same time.

lovesh · 2025-09-02T09:37:34Z

Cargo.toml

 serde_json = { version = "1.0"}
 serde-wasm-bindgen = "0.6.5"
-wasm-bindgen = "= 0.2.86"
+wasm-bindgen = "= 0.2.100"


Similar concern as with the serde_with dependency, i think upgrading it changed some serialisation but I am not that confident of my memory here. (Should have put a note for the reason of pinning it).

Here, this is a bit tricky as this update is needed for newer versions of rust, and also to avoid conflicting dependencies with the latest version of the crypto crates. (I've already tried updating the dock crypto crates to the latest version but this pinned version was a problem.)

I'm thinking about trying to load this library into crypto-wasm-ts and run the tests to make sure they succeed, then we can proceed on this. What do you think?

I'm thinking about trying to load this library into crypto-wasm-ts and run the tests to make sure they succeed, then we can proceed on this. What do you think?

Yes, for bigger upgrades, i run crypto-wasm-ts with crypto-wasm before publishing crypto-wasm itself. I make crypto-wasm a local dependency of crypto-wasm-ts. For some reason, yarn link sometimes didn't work so I had to manually remove the dependency's directory from node_modules when I updated the dependency (crypto-wasm here)

I struggled with that a bit yesterday, until I found that new versions of yarn introduced the portal keyword, and it works like this (in your package.json file).

"crypto-wasm-new": "portal:../crypto-wasm",

This works without issues for me so far.
The link command was removed in newer versions of yarn.

Hello Lovesh, I've worked on the crypto-wasm-ts to make sure the changes here are good (as we said above).

Now, I have this PR with the necessary changes to make everything work.
The necessary changes are in this PR docknetwork/crypto-wasm-ts#43

Note that in one commit docknetwork/crypto-wasm-ts@bed0d12 I had to remove a bunch of tests because we've removed the old proof-system dependency which means this support is gone now.

Does this look okay to you?

Sorry again for the long delay. Will try to be quick from now on. The build failed because there is no version of crypto-wasm for 0.34.0. I have asked the concerned folks to publish

@lovesh No problem! thank you!

But vesion 0.34 is not needed now.. the build will keep failing until we merge this PR as the changes here are a requirement for the other PR.

I could only test locally following your suggestion here: #19 (comment)

I think the next step in my opinion is to merge this PR if it doesn't have any issues, then do the release.

Oh, but the version 0.34 is published now. I was seeing errors in CI of this PR as

error Couldn't find any versions for "@docknetwork/crypto-wasm" that matches "0.34.0"

So after release, I re-ran that PR and now i see following error in CI as

error Your lockfile needs to be updated, but yarn was run with `--frozen-lockfile`.

My only request with this PR is that the version bump of serde-with as i am sure it will break downstream code. wasm-bindgen update might be fine.

I should go and update that PR to update to the new version.

As for this PR, the serde-with should be an easy change, specially if you feel strongly it will break downstream code 👍
I'll update you as soon as I get this done.

I reverted the version update for serde-with but now I'm having a problem with the tests in crypto-wasm-ts.. I'll get back here once I get them fixed.

lanterno changed the title ~~build: updates rust version and crates to latest versions~~ build: updates rust version and WASM crates to latest versions Sep 1, 2025

lanterno force-pushed the build/pushes-rust-version-and-crates-to-latest-versions branch from 1bff5a7 to 9ece847 Compare September 1, 2025 11:56

lanterno force-pushed the build/pushes-rust-version-and-crates-to-latest-versions branch from 4f0b5ca to fd85963 Compare September 1, 2025 14:20

lanterno added 2 commits September 1, 2025 16:38

build: updates rust version and crates to latest versions

2131a4d

ci: installs wasm-pack directly, to avoid installing old version

b4e6710

lanterno force-pushed the build/pushes-rust-version-and-crates-to-latest-versions branch from fd85963 to b4e6710 Compare September 1, 2025 14:39

lovesh reviewed Sep 2, 2025

View reviewed changes

lanterno mentioned this pull request Sep 8, 2025

Build/updates crypto wasm to version 0.34.0 docknetwork/crypto-wasm-ts#43

Draft

1 task

lanterno requested a review from lovesh October 2, 2025 11:38

lanterno mentioned this pull request Oct 13, 2025

experiment: Removes reference to old proof system library docknetwork/crypto-wasm-ts#44

Draft

fix: reverts to old versions to maintain compatibility downstream

dfd368d

build: updates rust version and WASM crates to latest versions #19

Are you sure you want to change the base?

build: updates rust version and WASM crates to latest versions #19

Conversation

lanterno commented Sep 1, 2025

Description

Next steps

PR checklist

Does this PR introduce a breaking change?

Which merge strategy will you use?

Uh oh!

lanterno commented Sep 1, 2025

Uh oh!

lanterno commented Sep 1, 2025

Uh oh!

lanterno commented Sep 1, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lanterno Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lanterno Nov 3, 2025 •

edited

Loading